Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine::loadPlugin change #1861

Open
Meakk opened this issue Jan 3, 2025 · 1 comment
Open

engine::loadPlugin change #1861

Meakk opened this issue Jan 3, 2025 · 1 comment
Labels
source:libf3d type:enhancement New feature or request
Milestone
3.1.0

Comments

@Meakk
Copy link
Member

Meakk commented Jan 3, 2025

Describe the bug
Right now, loadPlugin takes a string as argument which can be a path or a plugin name.
We should split the API and loadPlugin should take a fs::path only.
In other to load by name, we should have a new fs::path findPlugin(std::string_view) api.
@Meakk Meakk added type:enhancement New feature or request source:libf3d labels Jan 3, 2025
@Meakk Meakk added this to the 3.0.0 milestone Jan 3, 2025
@Meakk Meakk self-assigned this Jan 3, 2025
@Meakk Meakk added this to F3D Jan 3, 2025
@Meakk Meakk moved this to To do in F3D Jan 3, 2025
@Meakk
Copy link
Member Author

Meakk commented Jan 3, 2025

I took a look, it's more complicated than I expected because of static plugins.
Postponing to 3.1

@Meakk Meakk modified the milestones: 3.0.0, 3.1.0 Jan 3, 2025
@Meakk Meakk removed their assignment Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
source:libf3d type:enhancement New feature or request
Projects
F3D
Status: To do
Milestone
3.1.0
Development

No branches or pull requests
1 participant
@Meakk