Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a second USDZ crashes F3d #1834

Open
gerroon opened this issue Dec 24, 2024 · 5 comments
Open

Adding a second USDZ crashes F3d #1834

gerroon opened this issue Dec 24, 2024 · 5 comments
Assignees
Labels
source:usd type:bug Something isn't working
Milestone

Comments

@gerroon
Copy link

gerroon commented Dec 24, 2024

Describe the bug
It seems like the window only loads one USD, consequent USD loads crashes the app

To Reproduce
Steps to reproduce the behavior:
Use the USDs in the zip
load one of them.
Drag and drop the other one once the window loads

Expected behavior
It shouldn't crash

System Information:

  • OS: Win 11
  • GPU and GPU driver: RTX 2070

F3D Information
Paste the content of f3d --version: bin\f3d.exe --version prints nothing
This is the zip F3D-2.5.1-220-g55e20f54-Windows-x86_64.zip

Downloads.zip

@mwestphal
Copy link
Contributor

I reproduce using the binary on Linux, but not in my local build. Investigation needed.

@mwestphal
Copy link
Contributor

I reproduce with ANY .usdz. .usd does not have this issue.

@mwestphal mwestphal changed the title Adding a second USD crashes F3d Adding a second USDZ crashes F3d Dec 25, 2024
@mwestphal
Copy link
Contributor

may be a duplicate of #1499

@mwestphal mwestphal added type:bug Something isn't working source:usd labels Dec 25, 2024
@mwestphal mwestphal added this to the 3.0.0 milestone Dec 25, 2024
@mwestphal mwestphal added this to F3D Jan 3, 2025
@mwestphal mwestphal moved this to In progress in F3D Jan 3, 2025
@Meakk
Copy link
Member

Meakk commented Jan 3, 2025

The file Table.usdz outputs this warning when opening with --verbose:

Found material bindings on prim at path (/scene/Meshes/Sketchfab_model/root/GLTF_SceneRootNode/Cube_0/Object_4/Object_0) but MaterialBindingAPI is not applied on the prim

When opening it AFTER Longsword.usdz, it crashes in:

#0  0x00007fffea3636fe in pxrInternal_v0_24__pxrReserved__::TfDiagnosticMgr::PostWarning(pxrInternal_v0_24__pxrReserved__::TfEnum, char const*, pxrInternal_v0_24__pxrReserved__::TfCallContext const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::any, bool) const () from /usr/lib/libusd_ms.so
#1  0x00007fffea363a8a in pxrInternal_v0_24__pxrReserved__::TfDiagnosticMgr::WarningHelper::Post(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) const () from /usr/lib/libusd_ms.so
#2  0x00007fffea363b82 in pxrInternal_v0_24__pxrReserved__::Tf_PostWarningHelper(pxrInternal_v0_24__pxrReserved__::TfCallContext const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) () from /usr/lib/libusd_ms.so
#3  0x00007fffea363c8a in pxrInternal_v0_24__pxrReserved__::Tf_PostWarningHelper(pxrInternal_v0_24__pxrReserved__::TfCallContext const&, char const*, ...) ()
   from /usr/lib/libusd_ms.so
#4  0x00007fffeac2ed08 in pxrInternal_v0_24__pxrReserved__::UsdShadeMaterialBindingAPI::BindingsAtPrim::BindingsAtPrim(pxrInternal_v0_24__pxrReserved__::UsdPrim const&, pxrInternal_v0_24__pxrReserved__::TfToken const&, bool) () from /usr/lib/libusd_ms.so
....

Looking at the code, it seems like it crashes exactly where the warning is emitted.
See https://github.com/PixarAnimationStudios/OpenUSD/blob/9b0c13b2efa6233c8a4a4af411833628c5435bde/pxr/usd/usdShade/materialBindingAPI.cpp#L669

Longsword.usdz has a similar warning too

I tried chaining several usdz files without this warning, and it works just fine.

@Meakk
Copy link
Member

Meakk commented Jan 3, 2025

I'm moving this issue to 3.1

@Meakk Meakk modified the milestones: 3.0.0, 3.1.0 Jan 3, 2025
@Meakk Meakk moved this from In progress to To do in F3D Jan 3, 2025
@Meakk Meakk moved this from To do to Investigate in F3D Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source:usd type:bug Something isn't working
Projects
Status: Investigate
Development

No branches or pull requests

3 participants