From 26a9ac103a42cf95bf4a8b71cdabe989cb75a171 Mon Sep 17 00:00:00 2001 From: Dong Nguyen Date: Mon, 16 Aug 2021 22:27:11 +0700 Subject: [PATCH 1/2] v4.2.10 - merge pr #182 by @yakimka - update dependencies --- package.json | 10 +++++----- src/utils/retrieve.test.js | 7 +++++-- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/package.json b/package.json index 8b8a0fe6..b1276acf 100644 --- a/package.json +++ b/package.json @@ -1,5 +1,5 @@ { - "version": "4.2.9", + "version": "4.2.10", "name": "article-parser", "description": "To extract main article from given URL", "homepage": "https://ndaidong.github.io/article-parser-demo/", @@ -22,8 +22,8 @@ }, "dependencies": { "bellajs": "^9.3.0", - "cheerio": "^1.0.0-rc.9", - "debug": "^4.3.1", + "cheerio": "^1.0.0-rc.10", + "debug": "^4.3.2", "html-minifier-terser": "^5.1.1", "htmlparser2": "^6.1.0", "node-fetch": "^2.6.1", @@ -34,8 +34,8 @@ }, "devDependencies": { "eslint-config-goes": "^1.2.0", - "jest": "^27.0.4", - "nock": "^13.1.0" + "jest": "^27.0.6", + "nock": "^13.1.1" }, "keywords": [ "article", diff --git a/src/utils/retrieve.test.js b/src/utils/retrieve.test.js index 43e65fba..c7ad7010 100644 --- a/src/utils/retrieve.test.js +++ b/src/utils/retrieve.test.js @@ -22,6 +22,9 @@ test(`test retrieve from bad source`, async () => { nock(baseUrl).get(path).reply(200, '', { 'Content-Type': 'something/strange', }); - const result = await retrieve(url); - expect(result).toBe(null); + const fn = async () => { + const result = await retrieve(url); + return result; + }; + expect(fn()).rejects.toThrow(Error); }); From 5f827c35d265f4f25908810f399618db3dfdbeac Mon Sep 17 00:00:00 2001 From: Dong Nguyen Date: Mon, 16 Aug 2021 22:58:17 +0700 Subject: [PATCH 2/2] Update test script --- src/utils/retrieve.test.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/utils/retrieve.test.js b/src/utils/retrieve.test.js index c7ad7010..43e65fba 100644 --- a/src/utils/retrieve.test.js +++ b/src/utils/retrieve.test.js @@ -22,9 +22,6 @@ test(`test retrieve from bad source`, async () => { nock(baseUrl).get(path).reply(200, '', { 'Content-Type': 'something/strange', }); - const fn = async () => { - const result = await retrieve(url); - return result; - }; - expect(fn()).rejects.toThrow(Error); + const result = await retrieve(url); + expect(result).toBe(null); });