Fix Broken Test Case Due to Changed Error Message #1881
Merged
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
sahusiddharth
commented
Jan 25, 2025
| @@ -191,7 +191,9 @@ def validate_samples(self, samples: t.List[Sample]) -> t.List[Sample]: | |||
| first_sample_type = type(samples[0]) | |||
| for i, sample in enumerate(samples): | |||
| if not isinstance(sample, first_sample_type): | |||
| raise ValueError(f"Sample at index {i} is of type {type(sample)}, expected {first_sample_type}") | |||
| raise ValueError( | |||
There was a problem hiding this comment.
The extra space here due to make run-ci
|
Thanks @sahusiddharth, for this, merging this would solve the other PR i had requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a failing test case caused by changes introduced in PR #1879, which modified the error message format. The test has been updated to reflect the new error message, ensuring it passes successfully.