[FIX] - Fix for summarization edge case #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
dosubot
bot
added
size:M
|
@sky-2002 Sorry for the late merge. There were few important changes I had to make on this, please take a look at it so you know. |
|
Hey @jjmachan Can you check what's with the lining errors on those files (not modified in this PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a fix for the issue mentioned in #1108
However I have a points to discuss @shahules786 :
conciseness_scoreto penalize long summaries, but I also do not want to promote very very short and skimpy summaries, need to find a middle ground.averaginga good way to combineQA_scoreandconciseness_score?Given the conclusions we reach based on these discussion points, I will push more commits, let's keep this PR open till we resolve these points.