From 26b4930a895ec67361e0444ffc95a7f674374c9d Mon Sep 17 00:00:00 2001 From: Ganesh Rathinavel Medayil Date: Wed, 8 Jan 2025 20:56:49 +0530 Subject: [PATCH] fixed a lint issues in train run_id args --- src/ragas/metrics/base.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ragas/metrics/base.py b/src/ragas/metrics/base.py index 8fdcaef6f..14c2e1b89 100644 --- a/src/ragas/metrics/base.py +++ b/src/ragas/metrics/base.py @@ -355,7 +355,7 @@ def _optimize_demonstration( def train( self, path: t.Optional[str] = None, - run_id: str = None, + run_id: t.Optional[str] = None, demonstration_config: t.Optional[DemonstrationConfig] = None, instruction_config: t.Optional[InstructionConfig] = None, callbacks: t.Optional[Callbacks] = None, @@ -371,7 +371,7 @@ def train( ---------- path : str, optional Path to local JSON training data file - run_id : str + run_id : str, optional Direct run ID to fetch annotations demonstration_config : DemonstrationConfig, optional Configuration for demonstration optimization @@ -408,7 +408,7 @@ def train( if not path.endswith(".json"): raise ValueError("Train data must be in json format") dataset = MetricAnnotation.from_json(path, metric_name=self.name) - else: + if run_id is not None: dataset = MetricAnnotation.from_app( run_id=run_id, metric_name=self.name,