#48in24: Add analyzer feedback for Knapsack

[sanderploegsma]

The Knapsack exercise on the Java track is being featured in the #48in24 challenge, which means that we expect an influx of students attempting to solve it during that week.

It would be nice if the exercise contains some more content by that time.
One example of this is to add analyzer feedback for the exercise, to provide automated feedback on submitted solutions.

Adding analyzer feedback is done in three steps:

1. Create (or update) the .meta/design.md file for the exercise explaining what type of feedback the analyzer should provide (example for the Leap exercise).
2. Add the copy for the analyzer comments to exercism/website-copy.
3. Implement the analyzer rules in exercism/java-analyzer.

[sougat818]

Hello @sanderploegsma . Happy New Year. I have some time in the next few weeks to contribute. Please let me know if this is still worth doing or feel free to suggest a different issue.

Thanks 🙏

[kahgoh]

Hi @sougat818, I've assigned this to you to allow you to work on this one. As part mentioned in @sanderploegsma's comment above, the first part is that we'll need to decide what the analyzer should check and provide feedback for. Do you have thoughts on what the analyzer could check for?

[sougat818]

Hey @kahgoh , Thanks. I had a look at the analysers for existing exercises.

Essential

1. AvoidHardCodedTestCases

2. NoBuiltInMethods - There are multiple types for this one to discuss.
   I think these are trivial.

import java.util.Arrays;           // Arrays utility
import java.util.Collections;      // Collections utility

There are existing community solutions for Recursion with Memoization. I think these should be made into a third approach in the exercise. But if the goal of this exercise is to go towards Dynamic Programming then we can prevent it. We can move this to a different conversation as well, since this would potentially change the track.

import java.util.Map; 
import java.util.Set; 

There are a few solutions using Java Streams as well.

import java.util.stream.*;         // Streams

Actionable

3. MethodTooLong - Could be interesting to add for the dynamic programming solutions.
4. PreferDynamicProgramming - This would be similar to hamming.ShouldUseStreamFilterAndCount. Just nudging to try Dynamic programming solution as an optimal solution. But gets trickier with Recursion with Memoization solution.

Celebratory

5. ExemplarSolution - This is supposed to be for Concept only but may be a similar one just for The Exemplar Dynamic Programming solution. Goes well with 4. PreferDynamicProgramming

6. FeedbackRequest - Will add this as this is a new Analyser.