Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accuracy of PBC computations #29

Open
WardLT opened this issue May 10, 2023 · 2 comments
Open

Improve accuracy of PBC computations #29

WardLT opened this issue May 10, 2023 · 2 comments

Comments

@WardLT
Copy link
Collaborator

WardLT commented May 10, 2023

We see some differences in the forces acting on atoms that are symmetrically identical. Small, but enough to worry me.

See #28

@WardLT
Copy link
Collaborator Author

WardLT commented May 30, 2023

The problem is likely that our use of a fixed number of neighbors per atom. With high symmetry, there will be many atoms at the same distance in the neighbor shell and - due to the annoyances of numerics - atoms with the "same" structure are getting different subsets of atoms in a certain neighbor shell. Atoms at different points (but the same distance form the center) will lead to different energies and, especially, different forces (imbalance around the origin)

@WardLT
Copy link
Collaborator Author

WardLT commented May 30, 2023

I'm debating making this a #wontfix, as it only harmful on edge cases and holding a fixed number of neighbors is a choice we made for speed (fixed array sizes are faster on GPUs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant