Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esl-media): make video unfocusable if esl-media[role=presentation] #2829

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

grechihinrhp
Copy link
Contributor

Background video should bot be focusable

Closes: #2816

dependabot bot and others added 3 commits November 18, 2024 22:24
Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6.
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md)
- [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6)

---
updated-dependencies:
- dependency-name: cross-spawn
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
…s-spawn-7.0.6

chore(deps): bump cross-spawn from 7.0.3 to 7.0.6
@grechihinrhp grechihinrhp self-assigned this Dec 16, 2024
@grechihinrhp grechihinrhp requested a review from ala-n December 16, 2024 14:07
@ala-n ala-n added require squash No action from PR author required. Marks that current PR will be merged with squash and removed under discussion labels Dec 18, 2024
src/modules/esl-media/README.md Outdated Show resolved Hide resolved
@ala-n ala-n added the needs review The PR is waiting for review label Dec 18, 2024
Copy link

codeclimate bot commented Dec 18, 2024

Code Climate has analyzed commit 0851d34 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 71.4% (50% is the threshold).

This pull request will bring the total coverage in the repository to 65.3% (0.0% change).

View more on Code Climate.

@ala-n ala-n changed the base branch from main to main-beta December 18, 2024 13:18
@ala-n ala-n merged commit 44be58d into main-beta Dec 18, 2024
8 checks passed
@ala-n ala-n deleted the fix/focusable-bg-video-fix branch December 18, 2024 13:21
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
@ala-n
Copy link
Collaborator

ala-n commented Dec 18, 2024

🎉 This PR is included in version 5.0.0-beta.43 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs review The PR is waiting for review released on @beta require squash No action from PR author required. Marks that current PR will be merged with squash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 in esl-media]: background video should not be a focusable element
4 participants