Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when sending a friend request with a long message #1279

Open
robinlinden opened this issue Dec 7, 2024 · 0 comments
Open

Crash when sending a friend request with a long message #1279

robinlinden opened this issue Dec 7, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@robinlinden
Copy link
Collaborator

robinlinden commented Dec 7, 2024

Instead of crashing, we want some validation with nice UI feedback, similar to how the ToxID entry will tell people off if the ID is invalid.

im.tox.tox4j.core.exceptions.ToxFriendAddException: Error code: TOO_LONG
    at im.tox.tox4j.impl.jni.ToxCoreJni.toxFriendAdd(Native Method)
    at im.tox.tox4j.impl.jni.ToxCoreImpl.addFriend(ToxCoreImpl.scala:201)
    at ltd.evilcorp.domain.tox.ToxWrapper.addContact-cVeOlmQ(ToxWrapper.kt:96)
    at ltd.evilcorp.domain.tox.Tox.addContact-cVeOlmQ(Tox.kt:194)
    at ltd.evilcorp.domain.feature.ContactManager$add$1.invokeSuspend(ContactManager.kt:27)
    at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
    at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:101)
    at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:589)
    at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:832)
    at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:720)
    at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:707)
    Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@8321ffa, Dispatchers.Default]
@robinlinden robinlinden added bug Something isn't working good first issue Good for newcomers labels Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant