Build for Android 4.3 ?

[pboettcher]

Is there any way to build aTox for Android 4.3 ?

[robinlinden]

I had a look, and it's definitely buildable with some minor modifications.
I don't have a device with Android 4.3 available to test on right now, but https://robinli.eu/f/atox-for-jellybean.apk should work. It'd be very helpful if you could test it and get back to me. :D If it works, I guess I can officially support Android 4.3 for now!

The linked apk is a debug build of robinlinden@60626bb.

[pboettcher]

Yes, of course, I am always ready to test it on my phone. It is Samsung Galaxy S3 with latest firmware (4.3).

So, the first test is: I installed it, enabled network access in AFwall+, waited till it opens, tapped the "Import" button. The application waited for some seconds, then crashed.

03-16 14:57:45.815 2388-2521/? W/PackageManager: Package ltd.evilcorp.atox.debug desires unavailable shared library androidx.window.extensions; ignoring!
03-16 14:57:45.815 2388-2521/? W/PackageManager: Package ltd.evilcorp.atox.debug desires unavailable shared library androidx.window.sidecar; ignoring!
03-16 14:57:47.205 2388-2521/? W/PackageManager: Unknown permission android.permission.FOREGROUND_SERVICE in package ltd.evilcorp.atox.debug
03-16 14:59:36.535 18723-18723/? E/dalvikvm: Could not find class 'android.media.AudioAttributes$Builder', referenced from method ltd.evilcorp.atox.ui.NotificationHelper.createNotificationChannel
03-16 14:59:36.535 18723-18723/? W/dalvikvm: VFY: unable to resolve new-instance 95 (Landroid/media/AudioAttributes$Builder;) in Lltd/evilcorp/atox/ui/NotificationHelper;
03-16 14:59:41.500 18723-18723/? E/AndroidRuntime: FATAL EXCEPTION: main
android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.intent.action.OPEN_DOCUMENT typ=/ (has extras) }
at android.app.Instrumentation.checkStartActivityResult(Instrumentation.java:1669)
at android.app.Instrumentation.execStartActivity(Instrumentation.java:1441)
at android.app.Activity.startActivityForResult(Activity.java:3464)
at androidx.activity.ComponentActivity.startActivityForResult(ComponentActivity.java:647)
at androidx.core.app.ActivityCompat.startActivityForResult(ActivityCompat.java:239)
at androidx.activity.ComponentActivity$2.onLaunch(ComponentActivity.java:218)
at androidx.activity.result.ActivityResultRegistry$2.launch(ActivityResultRegistry.java:174)
at androidx.fragment.app.Fragment$9.launch(Fragment.java:3507)
at androidx.activity.result.ActivityResultLauncher.launch(ActivityResultLauncher.java:47)
at ltd.evilcorp.atox.ui.create_profile.CreateProfileFragment.onViewCreated$lambda-7$lambda-6(CreateProfileFragment.kt:104)
at ltd.evilcorp.atox.ui.create_profile.CreateProfileFragment.$r8$lambda$ZMlOkLJw06e8ApG5s0VSKizZFeM(CreateProfileFragment.kt)
at ltd.evilcorp.atox.ui.create_profile.CreateProfileFragment$$ExternalSyntheticLambda2.onClick(D8$$SyntheticClass)
at android.view.View.performClick(View.java:4475)
at android.view.View$PerformClick.run(View.java:18786)
at android.os.Handler.handleCallback(Handler.java:730)
at android.os.Handler.dispatchMessage(Handler.java:92)
at android.os.Looper.loop(Looper.java:176)
at android.app.ActivityThread.main(ActivityThread.java:5419)
at java.lang.reflect.Method.invokeNative(Native Method)
at java.lang.reflect.Method.invoke(Method.java:525)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1046)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:862)
at dalvik.system.NativeStart.main(Native Method)

03-16 15:08:41.710 19158-19158/ltd.evilcorp.atox.debug E/dalvikvm: Could not find class 'android.telephony.SubscriptionManager', referenced from method androidx.core.content.ContextCompat$LegacyServiceMapHolder.
03-16 15:08:41.710 19158-19158/ltd.evilcorp.atox.debug E/dalvikvm: Could not find class 'android.hardware.camera2.CameraManager', referenced from method androidx.core.content.ContextCompat$LegacyServiceMapHolder.
03-16 15:08:41.710 19158-19158/ltd.evilcorp.atox.debug E/dalvikvm: Could not find class 'android.view.accessibility.CaptioningManager', referenced from method androidx.core.content.ContextCompat$LegacyServiceMapHolder.
03-16 15:08:41.725 19158-19158/ltd.evilcorp.atox.debug E/dalvikvm: Could not find class 'android.media.AudioAttributes$Builder', referenced from method ltd.evilcorp.atox.ui.NotificationHelper.createNotificationChannel

... etc.
If yo want, I can list even more errors.

[robinlinden]

Please test https://robinli.eu/f/atox-for-jellybean.apk and let me know if it works then. :P Just downloading and running the .apk on your phone should be enough to open the installer. Again, it's a debug build, so you won't be able to use the chat history etc. when upgrading to the real release, but you'll be able to export your save (ID and contacts, pretty much) and import it when upgrading.

Just saw your edit. If you get me the logcat I'll see if I can fix the crash! Thank you for helping test it. :)

[robinlinden]

I think I found the reason for that error:
https://developer.android.com/guide/topics/providers/document-provider#client

On Android 4.3 and lower, if you want your app to retrieve a file from another app, it must invoke an intent such as ACTION_PICK or ACTION_GET_CONTENT. The user must then select a single app from which to pick a file and the selected app must provide a user interface for the user to browse and pick from the available files.

I'm using ACTION_OPEN_DOCUMENT (which works fine on Android 4.4 and newer), and Android Studio didn't flag this as an issue. :x It's easily fixed, though. Will take a look in a few hours, after work!

[robinlinden]

In the meantime, can you try creating a new profile instead of importing one? The crash you hit should only affect profile import and creating file transfers, so if you could have a look at other parts of aTox meanwhile, that would be good. :P

[pboettcher]

Creating a new profile works. The application is now idle, connected to the network. I haven't contacted anyone yet.

May be it is a good idea to make a top level exception handler (if it goes at all), so that the uncaught exceptions do not reach the OS and UI stays on the screen? In this case the software has a chance to relaunch its modules in case of crash.

By the way, I got a memory leak report from this debug version. Are you interested in such kind of information?