Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable DDEV telemetry for E2E tests #67

Open
alexkuc opened this issue Jan 8, 2025 · 0 comments
Open

Disable DDEV telemetry for E2E tests #67

alexkuc opened this issue Jan 8, 2025 · 0 comments
Assignees

Comments

@alexkuc
Copy link
Contributor

alexkuc commented Jan 8, 2025

From E2E PR #146. E2E was reverted because of catastrophic error as DDEV is not available initially in GitHub Runner:

$ ddev config global --instrumentation-opt-in=false
/bin/sh: 1: ddev: not found
error Command failed with exit code 127.

Start from here

private ddev(): void {
log('Installing DDEV...');
const curl = this.spawnSync.call('curl', ['-fsSL', 'https://ddev.com/install.sh'], { stdout: 'pipe' });
const bashArgs: string[] = [];
const ddevVersion = this.getDdevVersion();
if (ddevVersion) {
bashArgs.push('-s');
bashArgs.push(ddevVersion);
}
this.spawnSync.call('bash', bashArgs, { stdin: 'pipe', input: curl.stdout });
}

On an unrelated note, it looks like switch -s should not be here:

# Usage: install_ddev.sh or install_ddev.sh

@alexkuc alexkuc self-assigned this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant