Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Travis CI (#248) #251

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Conversation

DahyeonWoo
Copy link
Member

Delete Travis CI

@yeonns yeonns requested review from yeonns and designe September 12, 2022 07:32
@yeonns yeonns linked an issue Sep 12, 2022 that may be closed by this pull request
Copy link
Member

@yeonns yeonns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DahyeonWoo Thank you for removing unused CI/CD code!
coveralls is also not used anymore, but it would be good to integrate coveralls with github action to display our test coverage later. 😄

Copy link
Member

@designe designe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)
This contribution made euphony cleaner!

Let me merge with master 😄

@designe designe added the Clean Code Make some pretty & beautiful clean code label Sep 13, 2022
@designe designe merged commit 41c85a6 into euphony-io:master Sep 13, 2022
@designe
Copy link
Member

designe commented Sep 13, 2022

@DahyeonWoo
Here is euphony certificaiton :) thanks for your contribution!
https://promise.is/verified/euphony/certificates/DahyeonWoo

@designe designe added the osca-22 Contribution From Open Source Academy 2022 label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Code Make some pretty & beautiful clean code osca-22 Contribution From Open Source Academy 2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggested: remove unused CI/CD code
3 participants