Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TSDataset methods: add_columns_from_pandas -> add_features_from_pandas, update_columns_from_pandas -> update_features_from_pandas #567

Closed
d-a-bunin opened this issue Jan 16, 2025 · 3 comments
Assignees

Comments

@d-a-bunin
Copy link
Collaborator

🚀 Task description

Current names are suggesting inner structure.

Plan

  • Rename method TSDataset.add_columns_from_pandas -> TSDataset.add_features_from_pandas
  • Rename method TSDataset.update_columns_from_pandas -> TSDataset.update_columns_from_pandas
  • Replace all usuages of old names

Test cases

  • Fix tests after changing names

Additional context

Discussed in #435

@d-a-bunin d-a-bunin added this to the Major release 3.0 milestone Jan 16, 2025
@d-a-bunin d-a-bunin moved this from New to Todo in etna board Jan 17, 2025
@ArtemLiA
Copy link

Hi! I would like to do this, unless, of course, someone else is doing it now.

@d-a-bunin
Copy link
Collaborator Author

I'm assigning you to this task for now. It will be reassigned if time will come to finish the milestone in a short amount of time.

@d-a-bunin
Copy link
Collaborator Author

Closed by #593.

@github-project-automation github-project-automation bot moved this from In Review to Done in etna board Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants