Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Clustering fails of scikit-learn>=1.4 #516

Closed
1 task done
alex-hse-repository opened this issue Dec 1, 2024 · 2 comments
Closed
1 task done

[BUG] Clustering fails of scikit-learn>=1.4 #516

alex-hse-repository opened this issue Dec 1, 2024 · 2 comments
Assignees
@d-a-bunin
Labels
bug Something isn't working

Comments

@alex-hse-repository
Copy link
Collaborator

🐛 Bug Report

Since version 1.4 parameter affinity was renamed to metric in AgglomerativeClustering, so clustering fails with

TypeError: __init__() got an unexpected keyword argument 'affinity'

We have wrong constraints on scikit-learn version in pyproject.toml

Expected behavior

Clustering works fine after installing the library

How To Reproduce

Install library in environment with scikit-learn >= 1.4.0 and run example notebook with clustering

Environment

No response

Additional context

No response

Checklist

  • Bug appears at the latest library version
@alex-hse-repository alex-hse-repository added the bug Something isn't working label Dec 1, 2024
@d-a-bunin d-a-bunin moved this from New to Todo in etna board Dec 4, 2024
@d-a-bunin
Copy link
Collaborator

We have similar problem in #497.

@d-a-bunin d-a-bunin moved this from Todo to In Progress in etna board Dec 16, 2024
@d-a-bunin d-a-bunin mentioned this issue Dec 16, 2024
Merged
4 tasks
@d-a-bunin d-a-bunin self-assigned this Dec 16, 2024
@d-a-bunin d-a-bunin moved this from In Progress to In Review in etna board Dec 17, 2024
@d-a-bunin
Copy link
Collaborator

Closed by #529.

@github-project-automation github-project-automation bot moved this from In Review to Done in etna board Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@d-a-bunin d-a-bunin

Labels
bug Something isn't working
Projects
etna board
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alex-hse-repository @d-a-bunin