-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quarto website: Set fixed column widths for Arguments section? #306
Comments
Quick response before going to work.
For reference, |
I don't think we have a better solution than point 3. One could override the CSS with Thanks for the detailed answer, Vincent. |
Thanks both. Just so I understand, for 2 is the suggestion to duplicate the description for each newline argument? I'm not sure how to make multiple argument entries inherit the same description block otherwise... I'll think on a custom post processing command to add to the GA workflow file for 3. |
Actually I think we could change @vincentarelbundock do you have some examples in mind where |
that looks interesting. but sorry, no, it was too long ago and I forgot. My guess is packages with dots in variable names will be especially vulnerable |
Ok I'll do a mock package to try this out |
Well, tinyplot does have lots of dots in names (a bitter base R convention I had to swallow for the sake of consistency) 😏 So if it doesnt show up there we might be okay. |
Here's with #308:
With WDYT? |
I'm moving forward with this because it's easier to test on multiple existing packages than keeping the change in a PR. If something breaks, we can always revert it before releasing. |
Super, thanks @etiennebacher. I'll update to the dev version of altdoc for tinyplot and LYK if I notice any red flags. BTW is the preferred way to do this now (i.e., Suggest a remote package) via R-universe? |
I had no idea one could do that, I always keep a |
Got it, thanks. I just saw that the R-universe approach is failing anyway, since the altdoc build hasn't updated passed 0.5.0. |
(As an aside, the R-universe approach might be a nice solution for tidypolars if you want to get that on CRAN with the polars/neo-polars dependency remaining on R-universe.) |
Great idea! That didn't even cross my mind but it would be great to have it on CRAN, thanks 👍 I have to read more about this, it sounds a bit weird to me that a package can be on CRAN and its dependencies on R-universe but not on CRAN. I remember the CRAN team being very sensitive about downloading external dependencies so I'm surprised it's that "easy" to bypass. |
P.S. The updated tinyplot website looks great, thanks! https://grantmcdermott.com/tinyplot/man/tinyplot.html#arguments |
Subtitle: wrapping of long argument lists.
Hi folks,
This is a slightly difficult issue to describe, but easy to visualize. So let me first direct you over to the rendered webpage that prompted my question: https://grantmcdermott.com/tinyplot/man/tinyplot.html#arguments
As you can (hopefully) see, there is a large whitespace gap between the function arguments (
x
,y
, etc.) and their respective descriptions ("the x and y arguments provide the x and y coordinates for the plot."
, etc.) Indeed, the description column here is very thin.If you scroll further down the page, you'll see that the culprit is the very last
subset, na.action, drop.unused.levels
entry right at the bottom of the Arguments section. This long entry doesn't get wrapped and so all of the explanation text in the next column is pushed over to the right.Question: Is there are way to enforce max column widths of these respective column, and/or ensure wrapping so that we don't end up with excessive whitespace and squished description columns?
FWIW wrapping automatically takes place in the R console if you look at same help page locally (here: with
?tinyplot
in RStudio).Thanks for taking a look and apologies if I'm overlooking something obvious.
The text was updated successfully, but these errors were encountered: