Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isthmus Support #144

Open
tynes opened this issue Jan 24, 2025 · 4 comments
Open

Isthmus Support #144

tynes opened this issue Jan 24, 2025 · 4 comments

Comments

@tynes
Copy link

tynes commented Jan 24, 2025

When adding a hardfork, there are many places to modify to make sure that it works end to end. This process isn't documented and is prone to failure by forgetting to update a particular location. We need isthmus support in this package, it appears to be included in some places but it doesn't seem to be fully working and its not clear what needs to change to add isthmus support.

@emhane
Copy link

emhane commented Jan 27, 2025

possibly fixed in ethereum-optimism/op-reth#40

also ref, seems codebase needs updating wrt #143

@tynes
Copy link
Author

tynes commented Jan 27, 2025

Just merged ethereum-optimism/optimism#13962 which should pass thru the config in op-node for isthmus

@emhane
Copy link

emhane commented Jan 28, 2025

closed by #146

@emhane
Copy link

emhane commented Jan 28, 2025

possibly still GasPriceOracle needs updating though?
https://github.com/ethereum-optimism/op-reth/actions/runs/12993424665/job/36236448013#step:6:957
just getting this message for ecotone and fjord

t=2025-01-27T16:38:02+0000 lvl=info msg="Activating fjord in GasPriceOracle contract" sender=0x589A698b7b7dA0Bec545177D3963A2741105C7C9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants