Fix negative denominator in boost::rational during exponentiation.

ethereum · Nov 6, 2018 · 5c63575 · 5c63575
1 parent 88aee34
commit 5c63575
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/libsolidity/ast/Types.cpp b/libsolidity/ast/Types.cpp
@@ -1144,10 +1144,10 @@ TypePointer RationalNumberType::binaryOperatorResult(Token _operator, TypePointe
 				bigint denominator = optimizedPow(m_value.denominator(), absExp);
 
 				if (exp >= 0)
-					value = rational(numerator, denominator);
+					value = makeRational(numerator, denominator);
 				else
 					// invert
-					value = rational(denominator, numerator);
+					value = makeRational(denominator, numerator);
 			}
 			break;
 		}

diff --git a/libsolidity/ast/Types.h b/libsolidity/ast/Types.h
@@ -51,6 +51,14 @@ using FunctionTypePointer = std::shared_ptr<FunctionType const>;
 using TypePointers = std::vector<TypePointer>;
 using rational = boost::rational<dev::bigint>;
 
+inline rational makeRational(bigint const& _numerator, bigint const& _denominator)
+{
+	// due to a bug in certain versions of boost the denominator has to be positive
+	if (_denominator < 0)
+		return rational(-_numerator, -_denominator);
+	else
+		return rational(_numerator, _denominator);
+}
 
 enum class DataLocation { Storage, CallData, Memory };
 

diff --git a/test/libsolidity/syntaxTests/types/rational_negative_numerator_negative_exp.sol b/test/libsolidity/syntaxTests/types/rational_negative_numerator_negative_exp.sol
@@ -0,0 +1,5 @@
+contract C {
+    function f() public pure returns (int) {
+        return (-1 / 2) ** -1;
+    }
+}