Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory-to-memory assignment ICE #590

Closed
sbillig opened this issue Nov 8, 2021 · 1 comment · Fixed by #676
Closed

Memory-to-memory assignment ICE #590

sbillig opened this issue Nov 8, 2021 · 1 comment · Fixed by #676
Assignees
@Y-Nak

Comments

@sbillig
Copy link
Collaborator

sbillig commented Nov 8, 2021

What is wrong?

Code like

somestruct.x = somestruct.y
# or
x[0] = x[1]

causes a panic in yulgen::mappers::assignments::assign.

How can it be fixed

The code for the (Location::Memory, Location::Memory) assignment case should be replaced with an mcopym(typ, target, value), with mcopym redefined to take two pointers (to match scopys), and the existing mcopym that returns a new ptr renamed to mclone or something.
@Y-Nak Y-Nak mentioned this issue Feb 1, 2022
Closed
@Y-Nak Y-Nak self-assigned this Mar 3, 2022
@Y-Nak
Copy link
Member

Y-Nak commented Mar 11, 2022

will be resolved in #676

@Y-Nak Y-Nak mentioned this issue Mar 11, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Y-Nak Y-Nak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Codegen Y-Nak/fe
2 participants
@sbillig @Y-Nak