-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a way to mark folders and complete components as having a status #17
Comments
Yeah that would be awesome! I spent a good few hours trying to figure out how, but I don't think it's possible right now. Any ideas? |
Hi @etchteam, It says on the Readme.md that "You'll get an awesome label injected in the top toolbar and the sidebar.". But if I understand what going on so far this add-on only works for the toolbar, not the sidebar. Correct? |
@rodneysim we add a status dot label to the sidebar as well here: https://github.com/etchteam/storybook-addon-status/blob/master/src/register.tsx#L29 |
@gavmck maybe we can invest some time looking into this problem - what approaches did you try out, which didn't work? |
@Perni1984 Looking at the storybook files, I think it might be possible. You get the Can't remember why, but we only allow it on stories at the moment: https://github.com/etchteam/storybook-addon-status/blob/master/src/register.tsx#L33 Could just be out of date 🤷 Here is the tree construction file in storybook for reference: https://github.com/storybookjs/storybook/blob/aa74f4f6a05aec74068669d581f0abfa162ff6ec/lib/ui/src/components/sidebar/Tree.tsx |
Hey @gavmck thanks for the fast response. The problem is that storybook only "passes" I can see 3 options here:
I am not a fan of either one - but would you be happy to accept a PR that goes for 3.? - or do you have any other idea on how to get this done? |
Probably best to give 1 a spin first just to make sure, you never know and it's the "real" solution. |
(See attached screenshot for this to make a bit more sense)
I have the following structure for my components in Storybook:
Right now, only
Specific Instance
can have a status. It would be really nice if (probably in the storybookpreview.js
file), I could specify the status of theComponentName
(the overall component) andAtoms
(folder) that the component previews are defined within.Mostly, I'm just looking for this to be on the left nav bar, so I can see, at a glance, which of my folders is completely finished, and which components I need to work on yet.
The text was updated successfully, but these errors were encountered: