fix(mdns): Fix _mdns_append_fqdn excessive stack usage (IDFGH-14506) #744
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move "mdns_name_t name" declaration inside loop to move it out of scope and reclain stack space before recursion call.
Description
Move "mdns_name_t name" declaration inside loop to move it out of scope and reclaim stack space before the recursion call.
Related
Fixes #738
Testing
Tested using patched version on product build. Original was triggering a stack overflow. Stack overflow did not occur with patched version.
Checklist
Before submitting a Pull Request, please ensure the following: