fix(modem): callback rerun after final result (IDFGH-11611)

[dset0x]

When running DTE::command, data following an "OK" or "ERROR" response could cause the user callback to be re-run before got_line is cleared. If the callback then returned ESP_ERR_TIMEOUT (e.g. in the case of a URC), command_cb::result would now be command_result::TIMEOUT, while command_cb::signal still has command_cb::got_line set from the previous invocation. This then manifested as ESP_ERR_INVALID_STATE.

[dset0x]

I now see an alternate fix is already open here: #446

I have to say I prefer having the fix in one location, even though it can be debated what is the right place to have the check.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

Dimitrios Semitsoglou-Tsiapos seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[david-cermak]

Thanks for the fix!

I now see an alternate fix is already open here: #446

Yes, there's already another fix, currently under review.

I have to say I prefer having the fix in one location, even though it can be debated what is the right place to have the check.

Please feel free to chime in with your view on the #446 -- still waiting for reviews, all comments are welcome!