Add Certificate Bundle Support To WebSocket Client (IDFGH-9404)

[drguthrie]

Hello,

HTTP Client has support for the certificate bundle but WebsSocket Client does not. Is there any interest in adding support for the certificate bundle into WebSocket Client? I got it to work with only a few changes by following the code in the HTTP Client initialization method.

If there is interest I would be happy to make the changes and submit a pull request.

[david-cermak]

Hello @drguthrie

We welcome all contributions and the certificate bundle is a very useful addition to the websocket client.
Please check the contribution guidelines and post a PR with your changes. Thanks for the help!

[toastedcrumpets]

Hi @drguthrie,
Can you offer your patch code for review? I have the same problem. I will look at patching too but would like to collaborate on an update for ESP IDF.
Marcus

[david-cermak]

It seems to me that the certificate bundle is already supported:

esp-protocols/components/esp_websocket_client/include/esp_websocket_client.h

Line 120 in cffe268

esp_err_t (*crt_bundle_attach)(void *conf); /*!< Function pointer to esp_crt_bundle_attach. Enables the use of certification bundle for server verification, MBEDTLS_CERTIFICATE_BUNDLE must be enabled in menuconfig. Include esp_crt_bundle.h, and use `esp_crt_bundle_attach` here to include bundled CA certificates. */

Implemented in d56b5d9