Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mqtt does not url decode username or password (IDFGH-14444) (IDFGH-14446) #294

Open
0xFEEDC0DE64 opened this issue Jan 16, 2025 · 4 comments

Comments

@0xFEEDC0DE64
Copy link

Is your feature request related to a problem?

yes, our customers have mqtt servers with usernames and passwords containing spaces, @ and other special characters.

Telling them to correctly urlencode the parameters didnt help.

We only expose one single mqtt connection url and not the individual username and password fields.

Describe the solution you'd like.

The mqtt library should urldecode automatically if the username and passwords are taken from the url

Describe alternatives you've considered.

No response

Additional context.

No response

@github-actions github-actions bot changed the title mqtt does not url decode username or password mqtt does not url decode username or password (IDFGH-14444) Jan 16, 2025
@euripedesrocha
Copy link
Collaborator

@0xFEEDC0DE64 could you add more details on it? Also this is an issue on esp-mqtt right?

@0xFEEDC0DE64
Copy link
Author

Ah right, is esp-mqtt in the esp-idf repository? I will write there agian

@euripedesrocha euripedesrocha transferred this issue from espressif/esp-protocols Jan 16, 2025
@github-actions github-actions bot changed the title mqtt does not url decode username or password (IDFGH-14444) mqtt does not url decode username or password (IDFGH-14444) (IDFGH-14446) Jan 16, 2025
@euripedesrocha
Copy link
Collaborator

@0xFEEDC0DE64 I moved the issue.

Could you add more details on use case, failures that are preventing, if possible some test cases and the broker version so if we decide to implement the feature we can test it?

@erxbout
Copy link

erxbout commented Jan 26, 2025

I previously linked our issue a customer opened

Here is the link to the problem:
goecharger/go-eCharger-API-v2#258 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants