Branching never executes one branch (IDFGH-14306)

[safocl]

Answers checklist.

• I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
• I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
• I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report

In code

esp-idf/components/wpa_supplicant/src/rsn_supp/wpa.c

Line 245 in b5ac4fb

if (wpa_sm_get_bssid(sm, sm->bssid) < 0) {

the true branch will never start -- wpa_sm_get_bssid function always return 0:

esp-idf/components/wpa_supplicant/src/rsn_supp/wpa.c

Line 206 in b5ac4fb

return 0;

upd list of similar code:

esp-idf/components/wpa_supplicant/src/rsn_supp/wpa.c

Line 298 in b5ac4fb

if (wpa_sm_get_bssid(sm, bssid) < 0) {

[safocl]

esp-idf/components/wpa_supplicant/src/rsn_supp/wpa.c

Line 197 in b5ac4fb

* Returns: 0 on success, -1 on failure

this line means that the return is invalid.

[safocl]

https://w1.fi/wpa_supplicant/devel/wpa__i_8h_source.html contain the implementation of wpa_sm_get_bssid function:

169 static inline int wpa_sm_get_bssid(struct [wpa_sm](https://w1.fi/wpa_supplicant/devel/structwpa__sm.html) *sm, u8 *bssid)
170 {
171         WPA_ASSERT(sm->ctx->get_bssid);
172         return sm->ctx->get_bssid(sm->ctx->ctx, bssid);
173 }

is this what should be in place of the existing code?

[nopnop2002]

memcpy() function returns a pointer to dest.
So this comment is incorrect.

esp-idf/components/wpa_supplicant/src/rsn_supp/wpa.c

Line 197 in b5ac4fb

* Returns: 0 on success, -1 on failure

wpa_sm_get_bssid() always returns 0.

[safocl]

22897aa left dangerous code that now runs a non-existent (#ifndef ESP_SUPPLICANT).

esp-idf/components/wpa_supplicant/src/rsn_supp/wpa.c

Line 235 in d30e4d9

if (wpa_sm_get_bssid(sm, sm->bssid) < 0) {

[kapilkedawat]

@safocl ESP_SUPPLICANT is always defined for esp-idf supplicant, code was left intentionally.

[safocl]

@safocl ESP_SUPPLICANT is always defined for esp-idf supplicant, code was left intentionally.

ok