Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempting to manage Globus collections while not signed in correctly raises auth error but gives no user feedback #699

Open
bstrdsmkr opened this issue Dec 31, 2024 · 3 comments
Assignees

Comments

@bstrdsmkr
Copy link

Describe the bug

Attempting to manage Globus collections while not signed in correctly raises auth error but gives no user feedback

Desktop (please complete the following information):

  • OS: Linux
  • Browser and Version: Google Chrome Version 131.0.6778.204 (Official Build) (64-bit)

To Reproduce

  1. Load main page
  2. Do NOT sign in to Globus
  3. Select a file
  4. Press "Add to cart" button
  5. Switch to Cart tab
  6. Select dropdown under "Download your cart" and choose "Manage Collections"
  7. In the modal, type NCCS and press enter
  8. Note no feedback in UI
  9. Check dev tools Network tab to see HTTP 401 error returned from the backend

Expected behavior

Alert user that they must sign in in order to manage their Globus collections. Ideally, this alert would also direct them to the sign in flow.

Screenshots

Screenshot From 2024-12-31 09-54-16

Additional context

@sashakames
Copy link
Collaborator

Perhaps we want to log in the user when they start managing collections...

@downiec
Copy link
Collaborator

downiec commented Jan 11, 2025

I wasn't able to duplicate this issue when I initially tried because usually I have been able to do collection searches even when not logged in. Managing collections doesn't usually require logging in, at least when I ran my tests. I will still look into adding some U.I feedback however.

@bstrdsmkr
Copy link
Author

@downiec I think you're right -- I was testing locally with v1.2.0 and found later that I hadn't set the globus backend credentials correctly. This gave an error about "the signed in user [email protected] has no tokens for globus transfer." After fixing that, I'm also no longer able to reproduce this

This was referenced Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants