Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report specific robot attribute updates with SignalR #1796

Open
andchiind opened this issue Nov 18, 2024 · 1 comment · May be fixed by #1930
Open

Report specific robot attribute updates with SignalR #1796

andchiind opened this issue Nov 18, 2024 · 1 comment · May be fixed by #1930
Labels
backend Backend related functionality frontend Frontend related functionality improvement Improvement to existing functionality stale This issue or pull request already exists

Comments

@andchiind
Copy link
Contributor

Describe the improvement you would like to see
Currently when a field in the robot model is updated, we send the whole robot object to the frontend with SignalR. The issue with this is that when we update different fields around the same time, one of the updates may be ignored in the second signalR message. By only sending the specific field on the robot which has been updated we avoid this issue. There may be a potential backend solution as well, but this might be harder to implement.

How will this change existing functionality?
The robot values displayed on the frontend (status, battery level, pressure etc) will be more up to date. Currently we may need to wait for a new signalR message to get the previous battery level for instance.

How will this improvement affect the current Threat Model?
N/A

@andchiind andchiind added backend Backend related functionality frontend Frontend related functionality improvement Improvement to existing functionality labels Nov 18, 2024
@andchiind andchiind linked a pull request Jan 7, 2025 that will close this issue
10 tasks
@aeshub
Copy link
Contributor

aeshub commented Jan 22, 2025

This issue has automatically been marked as stale as there has been no activity for 60 days.

@aeshub aeshub added the stale This issue or pull request already exists label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend related functionality frontend Frontend related functionality improvement Improvement to existing functionality stale This issue or pull request already exists
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants