-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for WeakMap, WeakSet and Promise #53
Comments
I believe WeakMap and WeakSet don't hold or have an ability to iterate their keys. So they just can't be compared. Had no idea about Promise equality though. |
@illuminist they can't be deeply compared like objects, but you can check if they are the same object or not. |
Oh I see, I misread your explanation. Good day though. |
@fabiospampinato That is a breaking change, but it makes sense to not just iterate their properties and only compare by reference. PR is welcome. |
As an example the following returns true, instead it should return false:
I think this types of objects should be checked for strict equality.
The text was updated successfully, but these errors were encountered: