Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To align handling of the GTX outputs and #63 PR. #96

Closed
jerzyjamroz opened this issue Oct 13, 2023 · 5 comments · Fixed by #87, #95, #94, #63 or #110
Closed

To align handling of the GTX outputs and #63 PR. #96

jerzyjamroz opened this issue Oct 13, 2023 · 5 comments · Fixed by #87, #95, #94, #63 or #110

Comments

@jerzyjamroz jerzyjamroz self-assigned this Oct 13, 2023
@jerzyjamroz jerzyjamroz changed the title To align handling of the GDX outputs. To align handling of the GTX outputs. Oct 13, 2023
@zioven
Copy link
Contributor

zioven commented Oct 13, 2023

missing reference to commit: 64b5763
This commit provides the information so the driver maps the Inputs 16 and 17 as TCLKA and TCLKB (from MRF MTCA manual)
image

@jerzyjamroz
Copy link
Contributor Author

@zioven , I did extensive CLKA tests today and I think my impelemtation is the way to go. It works as expected.

In summary:

  • I will wait for you comment, once ok, I will merge this issue PRs (my part).
  • Then, let's aggree the names for the EVR models within "mrmEvrSetupPCI" command.
  • Then let's merge your code.

If anything, all ideas are welcome.

@jerzyjamroz jerzyjamroz changed the title To align handling of the GTX outputs. To align handling of the GTX outputs and #63 PR. Oct 16, 2023
@jerzyjamroz jerzyjamroz changed the title To align handling of the GTX outputs and #63 PR. To align handling of the GTX outputs and https://github.com/epics-modules/mrfioc2/pull/63 PR. Oct 16, 2023
@jerzyjamroz jerzyjamroz changed the title To align handling of the GTX outputs and https://github.com/epics-modules/mrfioc2/pull/63 PR. To align handling of the GTX outputs and #63 PR. Oct 16, 2023
@zioven
Copy link
Contributor

zioven commented Oct 17, 2023

@jerzyjamroz Can you elaborate on the tests performed and what shortcomings had the second solution?

I am just curious and would like to understand if and how the performance is affected by both solutions.

@jerzyjamroz
Copy link
Contributor Author

@zioven , the patches included here were used to run the CLKA output with 40-bit granularity (1 to 40-bit test was done successfully). The performance was on the level of ps. If you want more info, let's have a chat.

@jerzyjamroz
Copy link
Contributor Author

@zioven , I will merge PR #94 and #95 at the end of the day. If you are too busy then I will merge the @ZanMaticPratnemer code with those PRs included in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment