Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gaussFit incorrectly updates of distribution #59

Open
GoogleCodeExporter opened this issue Dec 29, 2015 · 1 comment
Open

gaussFit incorrectly updates of distribution #59

GoogleCodeExporter opened this issue Dec 29, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Running gaussFit as a subroutine and using a prior (for me through 
hmmFitFullyObs).

What is the expected output? What do you see instead?

The updating of the gaussian-InverseWishart distribution appears to be 
incorrect and yields a highly non PSD result.  


What version / revision of the product are you using? On what operating
system?
pmtk3 - Nov2012/Ubuntu

Please provide any additional information below.


Replaced line 37: SN = S0 + C + kappa0*m0*m0'-kappaN*muN*muN';

with

SN = S0 + C + kappa0/(kappa0+N)*(xbar-m0)*(xbar-m0)';

The problem appears to be fixed

Original issue reported on code.google.com by [email protected] on 23 Aug 2013 at 8:33

@GoogleCodeExporter
Copy link
Author

Moved to GitHub: https://github.com/probml/pmtk3/issues/59

Original comment by irosen on 4 Jan 2014 at 2:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant