Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace fc logging with spdlog #152

Closed
heifner opened this issue Apr 27, 2022 · 2 comments
Closed

Replace fc logging with spdlog #152

heifner opened this issue Apr 27, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@heifner
Copy link
Member

heifner commented Apr 27, 2022

This work was started, but not finished in EOSIO/eos#11062

  • fc logging is slow as everything is converted to variant and then to string.
  • fc logging lacks many features of modern logging frameworks: file logging, log rotation, log size limits, logging on differ thread, etc.
@heifner heifner added the enhancement New feature or request label Apr 27, 2022
@spoonincode
Copy link
Member

Do we have any metrics on the performance difference? Even unrealistic stuff (constantly log in a while loop for a few seconds? 🤷 ).

@stephenpdeos stephenpdeos moved this to Todo in ENF Engineering Jul 21, 2022
@heifner heifner mentioned this issue Jan 19, 2023
Closed
@arhag arhag mentioned this issue Feb 9, 2023
Open
@heifner heifner mentioned this issue May 3, 2023
Open
@heifner
Copy link
Member Author

heifner commented May 3, 2023

Moved to leap

@heifner heifner closed this as not planned Won't fix, can't repro, duplicate, stale May 3, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in ENF Engineering May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
ENF Engineering
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@heifner @spoonincode