Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated gas consumption test: normal EOS transfer #305

Closed
taokayan opened this issue Oct 9, 2024 · 1 comment · Fixed by #335
Closed

Automated gas consumption test: normal EOS transfer #305

taokayan opened this issue Oct 9, 2024 · 1 comment · Fixed by #335
Assignees

Comments

@taokayan
Copy link
Contributor

taokayan commented Oct 9, 2024

Develop automated tests to verify the gas consumption are same across the following executors (including using the latest gas algorithm with custom gas parameters):

  • executor in the evm-runtime contract
  • executor in evm-node
  • executor used in gas estimation via rpc
  • executor in transaction trace
  • executor in vmTrace

for the following transactions:

  • Sending EOS to an EVM account that doesn't exist from an EOS account via trustless bridge
  • Sending EOS to an EVM account that does exist from an EOS account via trustless bridge
  • Sending EOS to an EVM account that doesn't exist from an EVM account
  • Sending EOS to an EVM account that does exist from an EVM account
  • Sending EOS to an EOS account that does exist from an EVM account via trustless bridge
@elmato
Copy link
Contributor

elmato commented Oct 16, 2024

I think we can use eth-brownie to help us with the setup of the contracts (uniswap pools, nft, etc) and also with the interaction with the EVM since all our integration tests are using python already.

We can look into hardhat.config used in eos-evm-node and also scripts.

We will be measuring the executor in the evm-runtime contract by using the balance difference and the gas price?

@stephenpdeos stephenpdeos moved this from In Progress to Awaiting Review in EOS EVM Dec 6, 2024
@stephenpdeos stephenpdeos moved this from Awaiting Review to In Progress in EOS EVM Dec 6, 2024
@stephenpdeos stephenpdeos added this to the EOS EVM Node v2.0.0-rc1 milestone Dec 18, 2024
@arhag arhag linked a pull request Jan 17, 2025 that will close this issue
@stephenpdeos stephenpdeos moved this from In Progress to Awaiting Review in EOS EVM Feb 12, 2025
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in EOS EVM Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants