Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 'Second Opinion' option #772

Open
methecooldude opened this issue Oct 2, 2022 · 4 comments
Open

Add a 'Second Opinion' option #772

methecooldude opened this issue Oct 2, 2022 · 4 comments
Assignees

Comments

@methecooldude
Copy link
Member

There are a few times where account creators are unsure on something and needs a second opinion. I am proposing an update which adds a button to flag this.

I'm thinking maybe change the button on the queue list, which is normally #17a2b8 if there is a comment, to a red colo(u)r if a second opinion is requested

@Dane2007 Dane2007 self-assigned this Apr 6, 2023
@Dane2007
Copy link
Contributor

Dane2007 commented Apr 6, 2023

Screenshot 2023-04-06 at 12 12 26 AM

@methecooldude - is this similar to what you're thinking for how it shows on the queue list?

@methecooldude
Copy link
Member Author

@Dane2007 Either that, or change the request id button (the 000000) to red

@stwalkerster
Copy link
Member

How do you see this having an advantage over just leaving a comment and unreserving, and letting the next person to look at the request see the comment you left?


I don't really know where you'd (technically) store the status of the flag for this. You could (ab)use the status field, but then you'd have to cascade the new value to all the places we check that value. Alternatively, you could create a new database field for it.

The other option is that we scrap the blue/grey colouring on the zoom button which indicates the presence of any comment, and change it to the presence of a non-requester comment? It's not an explicit "I want a second opinion" highlight, but it would then indicate that someone else has looked at it enough to leave a comment.

@methecooldude
Copy link
Member Author

The other option is that we scrap the blue/grey colouring on the zoom button which indicates the presence of any comment, and change it to the presence of a non-requester comment? It's not an explicit "I want a second opinion" highlight, but it would then indicate that someone else has looked at it enough to leave a comment.

Yea, that would work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Incoming
Development

No branches or pull requests

3 participants