Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext_proc: GRPC tracing requests are always sampled regardless of the parent decision #37783

Open
cainelli opened this issue Dec 20, 2024 · 2 comments · May be fixed by #37794
Open

ext_proc: GRPC tracing requests are always sampled regardless of the parent decision #37783

cainelli opened this issue Dec 20, 2024 · 2 comments · May be fixed by #37794

Comments

@cainelli
Copy link
Contributor

cainelli commented Dec 20, 2024

Title: ext_proc GRPC tracing requests are always sampled regardless of the parent decision

Description: Essentially the exact same issue and possible fix seen in Lua httpCall (#33200) and ext_authz (#19343).

When introduced sampling support in ext_proc I overlooked this and can open a PR to fix it. I just would like to agree on the approach, I see some basic options.

  1. add .setSampled(absl::nullopt) in the StreamOptions (as we do in Lua httpCall and ext_authz)
  2. Change the default sample behavior as once considered to avoid the same issue in different places.
@phlax
Copy link
Member

phlax commented Dec 23, 2024

cc @tyxia @wbpcode

@phlax phlax added area/tracing area/grpc area/ext_proc and removed triage Issue requires triage labels Dec 23, 2024
@phlax
Copy link
Member

phlax commented Dec 23, 2024

note: envoy maintainers will be mostly on vacation until 6th jan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants