Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression tests #65

Open
the-frey opened this issue Jan 6, 2022 · 6 comments
Open

Regression tests #65

the-frey opened this issue Jan 6, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request priority
Milestone

Comments

@the-frey
Copy link
Contributor

the-frey commented Jan 6, 2022

Need simple regression tests for navigating to the main pages of the app.

@the-frey the-frey added the enhancement New feature or request label Jan 6, 2022
@the-frey the-frey added this to the V2 milestone Jan 24, 2022
@danwlsn
Copy link
Collaborator

danwlsn commented Jan 26, 2022

Going with cypress for the integration side of testing. I'll try and add as many happy paths as I can find but might need help highlighting some hairier paths through the application.

@danwlsn danwlsn self-assigned this Jan 26, 2022
@the-frey
Copy link
Contributor Author

Cypress makes sense.

Probably priorities in terms of user 'footfall' are:

  1. Mint
  2. Register/search page (/tokens/register)
  3. Public/serarch page (/ids/search)
  4. View pages (/ids/<id>, /tokens/<id> and the two variants: /dens/<id> & /<id>)

It feels like we should test /tokens/manage and /addresses/<address> but those are probably lower priority as AFAICR they are just read-based 🤔

Burn might be worth testing... although we have almost no evidence people are even burning.

@danwlsn
Copy link
Collaborator

danwlsn commented Jan 26, 2022

Hmmm, really struggling to "log in" as a wallet with cypress.
First tried loading keplr as a browser extension in cypress; that was a no-go.
Now attempting to stub hooks/useSigningCosmWasmClient to return a wallet address to state and bypass keplr. Any guidance here?

@the-frey
Copy link
Contributor Author

Interesting. I wonder what other people are doing. From a five-minute scan of other repos, there are unit tests for functions but no regression tests... 🙃

@danwlsn
Copy link
Collaborator

danwlsn commented Jan 26, 2022

Ahh good shout, didn't think about looking at other repo's implementations. I've found some eth projects that use cypress that are shedding light on possible paths 👍

@the-frey
Copy link
Contributor Author

Taking notes out of discord threads: https://github.com/CosmWasm/dApps/blob/master/packages/logic/src/service/sdk.ts#L36-L65

as recommended by ethan
Screenshot_2022-01-27_at_14 01 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority
Projects
None yet
Development

No branches or pull requests

2 participants