Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress enormous metadata section by 50% while making it friendlier #7989

Closed
3 tasks
JaroslavTulach opened this issue Oct 6, 2023 · 4 comments
Closed
3 tasks

Comments

@JaroslavTulach
Copy link
Member

JaroslavTulach commented Oct 6, 2023

Various META-DATA related issues

indicate the META-DATA section composes a major problem and a bottleneck in the stability of the whole parsing and editing infrastructure. In addition to that and independently of that the format of metadata is extremely verbose and deserves redesign. Instead of:

[{"index":{"value":127},"size":{"value":3}},"00000000-aaaa-bbbb-0000-000000000000"],

we should be writing:

[127,3,"00000000-aaaa-bbbb-0000-000000000000"

e.g. shorten each record by almost a half. Please modify the parser to support new, shorter format and make it more bulletproof.

Tasks

Preview Give feedback
@somebody1234
Copy link
Contributor

an alternative solution would to be to extract the metadata to separate files so that they become regular JSON, which can then be consumed using a regular JSON parser. not sure whether there are any major downsides to this approach though

@jdunkerley
Copy link
Member

@Frizi and I also discussed this change - we should make it, but we need to make sure we can still read the old format as well, and the change must work in both the new and old IDEs.

@JaroslavTulach
Copy link
Member Author

an alternative solution would to be to extract the metadata to separate files so that they become regular JSON,

Maybe, but my PR #7683 is blocked and I need (dirty) fix immediately, not a complete architecture rewrite in weeks.

which can then be consumed using a regular JSON parser. not sure whether there are any major
downsides to this approach though

I remember discussing that in the past and there was some reasoning behind having UUIDs at the end of the file. Any comment @wdanilo, @kustosz?

@JaroslavTulach JaroslavTulach changed the title Compress enormous metadata section by 50% while making it frendlier Compress enormous metadata section by 50% while making it friendlier Oct 17, 2023
@sylwiabr sylwiabr removed the triage label Feb 23, 2024
@JaroslavTulach JaroslavTulach moved this from ❓New to 🗄️ Archived in Issues Board Mar 12, 2024
@JaroslavTulach
Copy link
Member Author

Obsolete if #9257 gets implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants