Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify EPB PolyglotProxy with ReflectionLibrary #5176

Closed
wdanilo opened this issue Feb 5, 2023 · 1 comment
Closed

Simplify EPB PolyglotProxy with ReflectionLibrary #5176

wdanilo opened this issue Feb 5, 2023 · 1 comment
Labels
-compiler p-low Low priority x-chore Type: chore

Comments

@wdanilo
Copy link
Member

wdanilo commented Feb 5, 2023

This task is automatically imported from the old Task Issue Board and it was originally created by jaroslavtulach.
Original issue is here.


PolyglotProxy is responsible for delegating interop messages from Enso to JavaScript, Python, R. It is a repetitive piece code fragile to copy&paste programming. It has to be updated with every GraalVM update (e.g. #182845176) as the set of interop messages changes.

ReflectiveLibrary has been recently discovered by us that could simplify the whole proxying to a single send method.

Demonstrated on WithWarnings.

Can the same approach be applied to PolyglotProxy?

@JaroslavTulach
Copy link
Member

In any case, we can close this issue as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-compiler p-low Low priority x-chore Type: chore
Projects
None yet
Development

No branches or pull requests

3 participants