Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't open projects with Nightly package #11957

Closed
2 tasks done
sylwiabr opened this issue Jan 2, 2025 · 13 comments · Fixed by #12041
Closed
2 tasks done

Can't open projects with Nightly package #11957

sylwiabr opened this issue Jan 2, 2025 · 13 comments · Fixed by #12041
Assignees
Labels

Comments

@sylwiabr
Copy link
Member

sylwiabr commented Jan 2, 2025

Discord username

No response

What type of issue is this?

Permanent – Occurring repeatably

Is this issue blocking you from using Enso?

  • Yes, I can't use Enso because of this issue.

Is this a regression?

  • Yes, previous version of Enso did not have this issue.

What issue are you facing?

When creating a new project or opening existing one with Nightly packages newer then 16.12 error occurs
Enso 2025-01-02 11 24 04

Expected behaviour

Projects should run

How we can reproduce it?

No response

Screenshots or screencasts

No response

Logs

No response

Enso Version

Nightly 16.12 and newer

Browser or standalone distribution

Standalone distribution (local project)

Browser Version or standalone distribution

standalone

Operating System

MacOS

Operating System Version

No response

Hardware you are using

No response

@sylwiabr sylwiabr added --breaking Important: a change that will break a public API or user-facing behaviour --bug Type: bug --regression Important: regression labels Jan 2, 2025
@github-project-automation github-project-automation bot moved this to ❓New in Issues Board Jan 2, 2025
@sylwiabr sylwiabr removed the --breaking Important: a change that will break a public API or user-facing behaviour label Jan 2, 2025
@hubertp
Copy link
Collaborator

hubertp commented Jan 2, 2025

Likely caused by 96c5f31

@4e6
Copy link
Contributor

4e6 commented Jan 2, 2025

This may be a macOS issue. I have no problems with the latest nightly on Linux.

We had some issues with signing macOS package after the upgrade. Can be related #11914

@hubertp
Copy link
Collaborator

hubertp commented Jan 2, 2025

True, I can confirm that it works on Linux.

@hubertp hubertp self-assigned this Jan 2, 2025
@hubertp hubertp moved this from ❓New to 📤 Backlog in Issues Board Jan 2, 2025
@hubertp hubertp moved this from 📤 Backlog to 🔧 Implementation in Issues Board Jan 2, 2025
@hubertp
Copy link
Collaborator

hubertp commented Jan 2, 2025

It seems to be fine on Windows as well

@hubertp
Copy link
Collaborator

hubertp commented Jan 2, 2025

Fix merged, needs verification after next nightly is out.

@hubertp hubertp moved this from 🔧 Implementation to 🌟 Q/A review in Issues Board Jan 2, 2025
@hubertp
Copy link
Collaborator

hubertp commented Jan 3, 2025

Nightly appears to be still broken. Potentially the problem is in the signing process.

@hubertp hubertp moved this from 🌟 Q/A review to 🔧 Implementation in Issues Board Jan 3, 2025
@enso-bot
Copy link

enso-bot bot commented Jan 9, 2025

Hubert Plociniczak reports a new STANDUP for the provided date (2025-01-06):

Progress: Still doing some tweaks to NI integration, addressing PR review. Trying to diagnose again jline issue. It should be finished by 2025-01-09.

Next Day: Next day I will be working on the #11957 task. Continue investigating tickets

@enso-bot
Copy link

enso-bot bot commented Jan 9, 2025

Hubert Plociniczak reports a new STANDUP for the provided date (2025-01-07):

Progress: Merged NI integration work. Attempts to make jline initialize at build time, failed. Splitting jline into individual dependencies. Planning session. Fixed deployment of self-hosted runners. It should be finished by 2025-01-09.

Next Day: Next day I will be working on the #11957 task. Continue investigating tickets

mergify bot pushed a commit that referenced this issue Jan 9, 2025
A wild attempt at fixing MacOS signing process that prevents nightlies from working.
Also cleaned up dependencies for wrapper projects - `scala-compiler` was unnecessary and was introducing jline requirement.
Related to #11957.

# Important Notes
Not sure if this will fix the nightly as I'm still unable to confirm the real issue but this doesn't hurt.
@JaroslavTulach
Copy link
Member

I have just tried 2025.1.9.1 .dmg. I believe the different is in JAR manifests. The manifest of jline-native-3.26.3.jar is empty in the .dmg file:

Enso2.app/Contents/Resources/enso/dist/2025.1.1-nightly.2025.1.9.1/component$ unzip -p jline-native-3.26.3.jar META*MANI*
Manifest-Version: 1.0
Created-By: 21.0.2 (GraalVM Community)

while in the sbt buildEngineDistribution it contains a lot of attributes:

$ unzip -p ./built-distribution/enso-engine-0.0.0-dev-macos-aarch64/enso-0.0.0-dev/component/jline-native-3.26.3.jar META*MANI*
Manifest-Version: 1.0
Created-By: Apache Maven Bundle Plugin 5.1.9
Build-Jdk-Spec: 22
Automatic-Module-Name: org.jline.nativ
Bundle-Description: JLine
Bundle-License: https://opensource.org/licenses/BSD-3-Clause
Bundle-ManifestVersion: 2
Bundle-Name: JLine Native Library
Bundle-SymbolicName: org.jline.native
Bundle-Version: 3.26.3
Export-Package: org.jline.nativ;version="3.26.3"
Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.8))"
Tool: Bnd-6.3.1.202206071316

most imporantly the Automatic-Module-Name: org.jline.nativ is missing. That would probably be the cause of

Enso 2025-01-02 11 24 04

as well. If the Automatic-Module-Name: org.jline attribute was missing, then obviously the JVM module system could not find such module.

@hubertp
Copy link
Collaborator

hubertp commented Jan 10, 2025

Something is really odd. As you can see all the other jline deps are being correctly signed, while jline-native is clearly not.

> ls jlin*
jline.md                                                 jline-reader-3.26.3.jar:com.apple.cs.CodeSignature         jline-terminal-jna-3.26.3.jar
jline-native-3.26.3.jar                                  jline-terminal-3.26.3.jar                                  jline-terminal-jna-3.26.3.jar:com.apple.cs.CodeDirectory
jline-reader-3.26.3.jar                                  jline-terminal-3.26.3.jar:com.apple.cs.CodeDirectory       jline-terminal-jna-3.26.3.jar:com.apple.cs.CodeEntitlements
jline-reader-3.26.3.jar:com.apple.cs.CodeDirectory       jline-terminal-3.26.3.jar:com.apple.cs.CodeEntitlements    jline-terminal-jna-3.26.3.jar:com.apple.cs.CodeRequirements
jline-reader-3.26.3.jar:com.apple.cs.CodeEntitlements    jline-terminal-3.26.3.jar:com.apple.cs.CodeRequirements    jline-terminal-jna-3.26.3.jar:com.apple.cs.CodeRequirements-1
jline-reader-3.26.3.jar:com.apple.cs.CodeRequirements    jline-terminal-3.26.3.jar:com.apple.cs.CodeRequirements-1  jline-terminal-jna-3.26.3.jar:com.apple.cs.CodeSignature
jline-reader-3.26.3.jar:com.apple.cs.CodeRequirements-1  jline-terminal-3.26.3.jar:com.apple.cs.CodeSignature       jlink

@hubertp
Copy link
Collaborator

hubertp commented Jan 10, 2025

duh https://github.com/enso-org/enso/blob/develop/app/ide-desktop/client/tasks/signArchivesMacOs.ts#L225

GitHub
Enso Analytics is a self-service data prep and analysis platform designed for data teams. - enso-org/enso

@enso-bot
Copy link

enso-bot bot commented Jan 13, 2025

Hubert Plociniczak reports a new STANDUP for the provided date (2025-01-08):

Progress: Prepared PR that cleans up jline dependencies. Removed scala-compiler dependency that was pretty heavy. Not sure if that will address the issue as I cannot reproduce locally. Debugging lack of widgets on startup. It should be finished by 2025-01-09.

Next Day: Next day I will be working on the #11957 task. Continue investigating tickets

@enso-bot
Copy link

enso-bot bot commented Jan 13, 2025

Hubert Plociniczak reports a new STANDUP for the provided date (2025-01-09):

Progress: More testing of PR. Continued debugging widgets issue. Debugging issues with NI. It should be finished by 2025-01-09.

Next Day: Next day I will be working on the #11957 task. Continue investigating tickets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🟢 Accepted
Development

Successfully merging a pull request may close this issue.

4 participants