Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate slow opening of a project having large CSV file #10503

Closed
hubertp opened this issue Jul 10, 2024 · 4 comments · Fixed by #10515
Closed

Investigate slow opening of a project having large CSV file #10503

hubertp opened this issue Jul 10, 2024 · 4 comments · Fixed by #10515
Assignees
@JaroslavTulach
Labels
-compiler p-high Should be completed in the next sprint

Comments

@hubertp
Copy link
Collaborator

hubertp commented Jul 10, 2024 •
edited
Loading

When a project has a large data file (> 50MB) it will execute relatively slow in non-interactive mode and when loading a project in GUI.
@hubertp hubertp added p-high Should be completed in the next sprint -compiler -language-server labels Jul 10, 2024
@hubertp hubertp self-assigned this Jul 10, 2024
@hubertp hubertp moved this from ❓New to 🔧 Implementation in Issues Board Jul 10, 2024
@JaroslavTulach
Copy link
Member

JaroslavTulach commented Jul 10, 2024 •
edited
Loading

I have 16MB large .csv file:

  • with 2024.3.1-nightly.2024.7.10 it takes me 14s to Data.read it
  • with 2024.2.1-nightly.2024.6.14 it takes just 2s to Data.read it

After bisecting, the first bad commit is fe2cf49 coming from

@hubertp
Copy link
Collaborator Author

hubertp commented Jul 10, 2024 •
edited
Loading

Yes, I confirm. fe2cf49 takes 8.5s to parse 8MB file, while b5641aa just before it it takes 0.8s.

@JaroslavTulach JaroslavTulach mentioned this issue Jul 10, 2024
Merged
2 tasks
@JaroslavTulach
Copy link
Member

I have 16MB large .csv file:

* with `2024.3.1-nightly.2024.7.10` it takes me **14s** to `Data.read` it
* with `2024.2.1-nightly.2024.6.14` it takes just **2s** to `Data.read` it

With 0accf83 it takes 2200ms to read the 16MB large .csv file.

@enso-bot enso-bot bot mentioned this issue Jul 11, 2024
Closed
@mergify mergify bot closed this as completed in #10515 Jul 11, 2024
@mergify mergify bot closed this as completed in 077b86f Jul 11, 2024
@github-project-automation github-project-automation bot moved this from 🔧 Implementation to 🟢 Accepted in Issues Board Jul 11, 2024
@enso-bot enso-bot bot mentioned this issue Jul 11, 2024
Closed
@enso-bot
Copy link

enso-bot bot commented Jul 12, 2024

Hubert Plociniczak reports a new STANDUP for the provided date (2024-07-10):

Progress: Reproducing and debugging the problem. Turned out to be a recently introduced regression. Improving logging setup (#10500). It should be finished by 2024-07-10.

Next Day: Next day I will be working on the #10503 task. Continue profiling startup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JaroslavTulach JaroslavTulach

Labels
-compiler p-high Should be completed in the next sprint
Projects
Issues Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Speed up EnsoInputStream again enso-org/enso
2 participants
@hubertp @JaroslavTulach