Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Issue: sass-loader and webpack 2/3 #68

Open
2 tasks
steverabino opened this issue Aug 14, 2017 · 0 comments
Open
2 tasks

Dependency Issue: sass-loader and webpack 2/3 #68

steverabino opened this issue Aug 14, 2017 · 0 comments

Comments

@steverabino
Copy link
Member

steverabino commented Aug 14, 2017

What

Give a detailed description of WHAT this issue seeks to address or add to the build.

When running yarn, the following warning is shown

warning "[email protected]" has incorrect peer dependency "webpack@^2.0.0 || >= 3.0.0-rc.0 || ^3.0.0".

I believe if we're going to be using webpack v1, we need to use this branch of sass-loader: https://github.com/webpack-contrib/sass-loader/tree/archive/webpack-1 (not sure the release version number)

How

  • Use version of sass-loader compatible with webpack v1 OR
  • Upgrade webpack to version 2 or 3

Considerations

  • This is not currently breaking anything, but probably not good practice, and some functionality of sass-loader will not work with webpack v1

  • Is this issue dependent on any others? No

  • Should the assigned consult with anyone in particular before proceeding? No

To Do

  • Use version of sass-loader compatible with webpack v1 OR
  • Upgrade webpack to version 2 or 3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant