Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to exclude non-game categories #1389

Open
steven-sheehy opened this issue Nov 8, 2024 · 0 comments
Open

No way to exclude non-game categories #1389

steven-sheehy opened this issue Nov 8, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@steven-sheehy
Copy link

steven-sheehy commented Nov 8, 2024

Is your feature request related to a problem?

I'm using Redump's 3do dat to filter the 3do dumps to produce a 1g1r set. Unfortunately, the report it generates includes non-game items like coverdiscs, multimedia, video, etc. It seems like while igir does filter some categories like demos and applications, it does not support the full extent of categories supported by redumper.

I can use regex filters to attempt to exclude some by name but this is more brittle than using the <category> in the dat.

Describe the solution you'd like

I'd like the ability to include only games and exclude all other categories. This could be a new --only-games flag or the existing --only-retail could be changed to only include games by default. While new options could be added for every category to be excluded like --no-multimedia, etc., it might be easier to just focus on an only games option. Alternatively, it might be more flexible to add a flag that allows you to pass one or more enum categories like --include-categories games or --exclude-categories multimedia,video,coverdiscs.

Additional context

Executed command:

igir report --dat "Panasonic - 3DO Interactive Multiplayer - Datfile (655) (2024-11-06 10-50-22).zip" --input "Redump/Panasonic - 3DO Interactive Multiplayer" --single --prefer-good --prefer-verified --prefer-revision newer --prefer-language EN --prefer-region USA,WORLD,CAN,EUR,UK,AUS,NZ,JPN --only-retail

Sample rows that still show as FOUND:

Panasonic - 3DO Interactive Multiplayer,Live! 3DO Magazine CD-ROM 1 (Japan),FOUND,/Redump/Panasonic - 3DO Interactive Multiplayer/Live! 3DO Magazine CD-ROM 1 (Japan).zip,false,false,true,false,false,false,false,false,false,false,false,false,false
Panasonic - 3DO Interactive Multiplayer,Live! 3DO Magazine CD-ROM 10 (Japan),FOUND,/Redump/Panasonic - 3DO Interactive Multiplayer/Live! 3DO Magazine CD-ROM 10 (Japan).zip,false,false,true,false,false,false,false,false,false,false,false,false,false
Panasonic - 3DO Interactive Multiplayer,Icebreaker II (USA) (Bonus Disk) (Unl),FOUND,/Redump/Panasonic - 3DO Interactive Multiplayer/Icebreaker II (USA) (Bonus Disk) (Unl).zip,false,false,true,true,false,false,false,false,false,false,false,false,false
Panasonic - 3DO Interactive Multiplayer,"Naoko to Hide-bou - Kanji no Tensai 1 - Bushu-hen, Bushu no Namae ga Tanoshii Chou Kioku-hou (Japan)",FOUND,"/Redump/Panasonic - 3DO Interactive Multiplayer/Naoko to Hide-bou - Kanji no Tensai 1 - Bushu-hen, Bushu no Namae ga Tanoshii Chou Kioku-hou (Japan).zip",false,false,true,false,false,false,false,false,false,false,false,false,false
@steven-sheehy steven-sheehy added the enhancement New feature or request label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant