Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-Duplication of DAT Files appears to only use size for comparisons. #1368

Open
wormley opened this issue Oct 6, 2024 · 0 comments
Open
Labels
potential-bug A potential issue that needs confirmation and/or triage

Comments

@wormley
Copy link

wormley commented Oct 6, 2024

Paste the command

igir report -vvv --dat tosec-dat/TOSEC-PIX/ --input TOSEC-PIX-ROM/

Describe the bug

When loading a large number of DAT files where some have the same file-size then all but one of the same size DATs appear to be ignored.

[22:02:16.418] TRACE: DATScanner: found 1,132 DAT files
[22:02:29.790] TRACE: DATScanner: parsing 1,025 DAT files

ls tosec-dat/TOSEC-PIX/.dat | wc -l
1132
ls -l tosec-dat/TOSEC-PIX/
.dat | awk '{print $5}' | sort | uniq -c | wc -l
1025
(Number of unique file sizes)

Expected behavior

All 1132 files should be parsed.

Debug logs

igir.trace.txt.gz

DAT(s) used

https://www.tosecdev.org/downloads/category/58-2024-05-17

igir version

v3.0.1

Node.js version

N/A

Operating system

Debian 12.5

Additional context

No response

@wormley wormley added the potential-bug A potential issue that needs confirmation and/or triage label Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential-bug A potential issue that needs confirmation and/or triage
Projects
None yet
Development

No branches or pull requests

1 participant