From 2b6bff09624e4796afc5e35a509083396626a8a2 Mon Sep 17 00:00:00 2001
From: Romeo Dumitrescu <romeo@drc.ro>
Date: Mon, 14 Oct 2024 10:27:00 +0300
Subject: [PATCH] refactor(Problems): update method calls and improve code
 readability

- Replaced direct method calls with TypedResults class in ProblemExtensions.cs
- Improved code readability by adjusting comment indentation and formatting
- Updated the documentation comments for better clarity in ProblemException.cs and ProblemExtensions.cs
---
 .../Problems/ProblemExtensions.cs             | 26 +++++++++----------
 src/ES.FX/Problems/ProblemException.cs        |  6 ++---
 src/ES.FX/Problems/ProblemExtensions.cs       |  6 ++---
 3 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/src/ES.FX.Microsoft.AspNetCore/Problems/ProblemExtensions.cs b/src/ES.FX.Microsoft.AspNetCore/Problems/ProblemExtensions.cs
index 1e4eef1..e905230 100644
--- a/src/ES.FX.Microsoft.AspNetCore/Problems/ProblemExtensions.cs
+++ b/src/ES.FX.Microsoft.AspNetCore/Problems/ProblemExtensions.cs
@@ -2,10 +2,10 @@
 using System.Text.Json;
 using ES.FX.Problems;
 using JetBrains.Annotations;
+using Microsoft.AspNetCore.Http;
 using Microsoft.AspNetCore.Http.HttpResults;
 using Microsoft.AspNetCore.Mvc;
 using Microsoft.AspNetCore.WebUtilities;
-using static Microsoft.AspNetCore.Http.TypedResults;
 using ValidationProblem = ES.FX.Problems.ValidationProblem;
 
 namespace ES.FX.Microsoft.AspNetCore.Problems;
@@ -32,9 +32,9 @@ public static class ProblemExtensions
     };
 
     /// <summary>
-    /// Formats a <see cref="Problem"/> as <see cref="ProblemDetails"/>
+    ///     Formats a <see cref="Problem" /> as <see cref="ProblemDetails" />
     /// </summary>
-    /// <param name="problem">The source <see cref="Problem"/></param>
+    /// <param name="problem">The source <see cref="Problem" /></param>
     [PublicAPI]
     public static ProblemDetails AsProblemDetails(this Problem problem)
     {
@@ -72,37 +72,37 @@ public static ProblemDetails AsProblemDetails(this Problem problem)
     }
 
     /// <summary>
-    /// Returns an <see cref="UnprocessableEntity{ProblemDetails}"/> result with the specified <see cref="Problem"/>
+    ///     Returns an <see cref="UnprocessableEntity{ProblemDetails}" /> result with the specified <see cref="Problem" />
     /// </summary>
     [PublicAPI]
     public static UnprocessableEntity<ProblemDetails> AsUnprocessableEntityResult(this Problem problem) =>
-        UnprocessableEntity(problem.AsProblemDetails());
+        TypedResults.UnprocessableEntity(problem.AsProblemDetails());
 
     /// <summary>
-    /// Returns a <see cref="BadRequest{ProblemDetails}"/> result with the specified <see cref="Problem"/>
+    ///     Returns a <see cref="BadRequest{ProblemDetails}" /> result with the specified <see cref="Problem" />
     /// </summary>
     [PublicAPI]
     public static BadRequest<ProblemDetails> AsBadRequestResult(this Problem problem) =>
-        BadRequest(problem.AsProblemDetails());
+        TypedResults.BadRequest(problem.AsProblemDetails());
 
     /// <summary>
-    /// Returns a <see cref="Conflict{ProblemDetails}"/> result with the specified <see cref="Problem"/>
+    ///     Returns a <see cref="Conflict{ProblemDetails}" /> result with the specified <see cref="Problem" />
     /// </summary>
     [PublicAPI]
     public static Conflict<ProblemDetails> AsConflictResult(this Problem problem) =>
-        Conflict(problem.AsProblemDetails());
+        TypedResults.Conflict(problem.AsProblemDetails());
 
     /// <summary>
-    /// Returns an <see cref="Ok{ProblemDetails}"/> result with the specified <see cref="Problem"/>
+    ///     Returns an <see cref="Ok{ProblemDetails}" /> result with the specified <see cref="Problem" />
     /// </summary>
     [PublicAPI]
     public static Ok<ProblemDetails> AsOkResult(this Problem problem) =>
-        Ok(problem.AsProblemDetails());
+        TypedResults.Ok(problem.AsProblemDetails());
 
     /// <summary>
-    /// Returns a <see cref="ProblemHttpResult"/> result with the specified <see cref="Problem"/>
+    ///     Returns a <see cref="ProblemHttpResult" /> result with the specified <see cref="Problem" />
     /// </summary>
     [PublicAPI]
     public static ProblemHttpResult AsProblemResult(this Problem problem) =>
-        Problem(problem.AsProblemDetails());
+        TypedResults.Problem(problem.AsProblemDetails());
 }
\ No newline at end of file
diff --git a/src/ES.FX/Problems/ProblemException.cs b/src/ES.FX/Problems/ProblemException.cs
index 8ac3595..e1ec77e 100644
--- a/src/ES.FX/Problems/ProblemException.cs
+++ b/src/ES.FX/Problems/ProblemException.cs
@@ -1,14 +1,14 @@
 namespace ES.FX.Problems;
 
 /// <summary>
-/// Exception that is thrown when a <see cref="Problem"/> occurs. Contains the <see cref="Problem"/> that occured.
+///     Exception that is thrown when a <see cref="Problem" /> occurs. Contains the <see cref="Problem" /> that occured.
 /// </summary>
-/// <param name="problem">The <see cref="Problem"/></param>
+/// <param name="problem">The <see cref="Problem" /></param>
 public class ProblemException(Problem problem)
     : Exception($"A problem of type '{problem.Type}' occured. See '{nameof(Problem)}' for more details")
 {
     /// <summary>
-    /// The source <see cref="Problem"/>
+    ///     The source <see cref="Problem" />
     /// </summary>
     public Problem Problem { get; } = problem;
 }
\ No newline at end of file
diff --git a/src/ES.FX/Problems/ProblemExtensions.cs b/src/ES.FX/Problems/ProblemExtensions.cs
index ae17407..2749a40 100644
--- a/src/ES.FX/Problems/ProblemExtensions.cs
+++ b/src/ES.FX/Problems/ProblemExtensions.cs
@@ -6,10 +6,10 @@ namespace ES.FX.Problems;
 public static class ProblemExtensions
 {
     /// <summary>
-    /// Throws a <see cref="ProblemException"/> with the specified <see cref="Problem"/>
+    ///     Throws a <see cref="ProblemException" /> with the specified <see cref="Problem" />
     /// </summary>
-    /// <param name="problem">The <see cref="Problem"/></param>
+    /// <param name="problem">The <see cref="Problem" /></param>
     /// <exception cref="ProblemException"></exception>
-    public static void Throw(this Problem problem) => 
+    public static void Throw(this Problem problem) =>
         throw new ProblemException(problem);
 }
\ No newline at end of file