Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code refactoring #27

Open
jdchoi77 opened this issue Nov 17, 2018 · 0 comments
Open

Code refactoring #27

jdchoi77 opened this issue Nov 17, 2018 · 0 comments
Assignees
@imgarylai
Labels
enhancement

Comments

@jdchoi77
Copy link
Member

  • Put elit/lemmatization and elit/token_tagger under elit/nlp.
  • Create elit/model.py, move the classes in model/cnn_model.py and model/rnn_model.py to elit/model.py, and remove elit/model.
  • Remove elit/state.py (we no longer use it?)
  • Remove resources/morph_analyzer and rename resources/lemmatizer to resources/morph_analyzer. You probably need to reconfigure the resource path for EnglishMorphAnalyzer (we probably don't need EnglishLemmatizer any more).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@imgarylai imgarylai

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdchoi77 @imgarylai