Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand on grade_notification_cache #67

Open
elijaholmos opened this issue Sep 10, 2022 · 1 comment
Open

expand on grade_notification_cache #67

elijaholmos opened this issue Sep 10, 2022 · 1 comment

Comments

@elijaholmos
Copy link
Owner

currently implementation is only utilized during user creation, to store grades that have already been published prior to account connection.

expand implementation to prevent the duplication of grade notifications. do consider, however, that professors can remove & reupload grades for the same assessment. I am not sure if UserCourseClassAssessmentGrade objects have their own unique ID, and whether or not this ID changes when grades are removed & reuploaded.

@elijaholmos
Copy link
Owner Author

I believe another use case could be additional notification security:

  • When a new grade is, for some reason, not detected in the HaloWatcher interval, this safety net would catch it and still provide a notification
  • If the grade status is PUBLISHED and the grade ID does not appear in the grade_notification_cache, then we know the user has not been notified, and should we be clear to send a notification
    • what about users with notifications disabled via settings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant