Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDR report does not handle NaN values #1788

Open
orenniapete opened this issue Jan 22, 2025 · 0 comments
Open

EDR report does not handle NaN values #1788

orenniapete opened this issue Jan 22, 2025 · 0 comments
Labels
Bug Something isn't working Triage 👀

Comments

@orenniapete
Copy link

orenniapete commented Jan 22, 2025 •
edited by github-actions bot
Loading

Describe the bug
The EDR report breaks when test data contains NaN values

To Reproduce
Steps to reproduce the behavior:

  1. Generate a test to fail when a column value contains NaN values:
Image
  1. Create the EDR report
  2. View the html report, it should not break the embedded json:
Image

Expected behavior
NaN values should be in quotes to prevent the json data from becoming invalid

Environment (please complete the following information):

  • Elementary CLI (edr) version:0.16.1
  • Elementary dbt package version: 0.16.1
  • dbt version you're using: 1.6.6
  • Data warehouse: Snowflake

Would you be willing to contribute a fix for this issue?
I am not a coder, just a user of the library/report
@orenniapete orenniapete added Bug Something isn't working Triage 👀 labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Triage 👀
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@orenniapete