"Set up Secure backup" toast shown while the current session is not verified

[BillCarsonFr]

Web is showing this toast

But the current session is not verified, as can be seen here:

Setting up secure backup from an unverified session should be impossible.

Steps to reproduce

• I initially had a web session logged in, with all setup properly
• Then I logged in EXI and said I couldn't verify and that I forgot my recovery code
• I did the reset flow on EXI.

This flow is resets the identity, creating a new Key Storage, and deleting 4S (recovery).

Additional info

From web

Clicking on restore fails with:

If I try to send a message, I see that

If I try to proceed with Set up secure backup:

It asks twice for the passphrase, then there is a 3rd modal ( for which I have no passphrase/key that works)

[richvdh]

The problem here is that "Set up Secure backup" doesn't really mean "Set up Secure backup"; rather it is a catch-all "fix my encryption" toast.

It's hitting this path:

element-web/src/DeviceListener.ts

Lines 309 to 312 in 12932e2

	if (!crossSigningReady) {
	// This account is legacy and doesn't have cross-signing set up at all.
	// Prompt the user to set it up.
	showSetupEncryptionToast(SetupKind.SET_UP_ENCRYPTION);