Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Device dehydration: "Reset recovery" with dehydrated devices enabled prompts for security key just after setting it #29130

Closed
richvdh opened this issue Jan 29, 2025 · 1 comment · Fixed by #29143
Closed

Device dehydration: "Reset recovery" with dehydrated devices enabled prompts for security key just after setting it #29130

richvdh opened this issue Jan 29, 2025 · 1 comment · Fixed by #29143
Assignees
@richvdh
Labels
A-E2EE-Dehydration O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@richvdh
Copy link
Member

richvdh commented Jan 29, 2025 •
edited
Loading

STR:

  1. Enable MSC3814 on synapse (experimental_features: msc2697_enabled: false msc3814_enabled: true)
  2. Enable MSC3814 flag in well-known (extra_well_known_client_content: { "org.matrix.msc3814": true })
  3. Log in. Observe:
    Image
  4. Click "Verify with Security Key or Phrase".
  5. Click "Reset all"
  6. Click "Reset" to confirm. Observe:
    Image
  7. Either generate a key or enter a phrase
  8. Observe:
    Image
  9. Click "continue"
  10. Enter account password

Expected

Secrets are correctly reset

Actual

Image

It's prompting me for the security key which I have literally just set.

Notes

This only happens if a dehydrated device previously existed.

If you enter the security key, then everything is reset correctly, but then you end up back at the start: #29120

You can also hit this flow from within the settings panel, by clicking this Reset button, though note that said button is being removed as part of #26468:

Image
@dosubot dosubot bot added O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect labels Jan 29, 2025
This was referenced Jan 29, 2025
Closed
Open
@richvdh richvdh added S-Minor Impairs non-critical functionality or suitable workarounds exist A-E2EE-Dehydration and removed S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Jan 29, 2025
@richvdh richvdh self-assigned this Jan 29, 2025
@richvdh
Copy link
Member Author

richvdh commented Jan 29, 2025

It's prompting me for the security key which I have literally just set.

Actually no, it is prompting me for the old security key.

@richvdh richvdh mentioned this issue Jan 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richvdh richvdh

Labels
A-E2EE-Dehydration O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop showing a dialog prompting the user to enter an old recovery key element-hq/element-web
1 participant
@richvdh