Incorrect or correct security phrase for setting up recovery silently fails

[tuxayo]

Steps to reproduce

1. A prompt suggests me to "set up recovery". When I put my security Phrase and hit "continue" it just closes with the message suggesting "set up recovery" still there.
2. If I use my security key, the UI tells me it's correct but when I hit "continue", the same happens as above.
3. In the JS console I see among other things:
   Olm device has private keys and they are saved in secret storage; doing nothing
   Not saving backup key to secret storage: no backup key
4. When I put a wrong security phrase, I get in the console "accessSecretStorage: error during operation Error: Error decrypting secret m.cross_signing.master: bad MAC"
5. With the UI just closing the modal and the prompt "Set up recovery" still there.

That's when I found #13180

Outcome

What did you expect?

Happy path working.
Unhappy path not having a JS error and instead having appropriate feedback in the UI.

Operating system

EndeavourOS (Arch Linux based)

Browser information

Firefox 134.0.2

URL for webapp

https://app.element.io

Application version

No response

Homeserver

No response

Will you send logs?

Yes

[richvdh]

I'm not really following the description here.

Please don't tell us what the JS console says; it's probably misleading.

Please do share screenshots of what you see, along with clear steps to repeat. If you think there is more than one problem, open separate issues: we can always close duplicates, but trying to manage two different problems on the same issue is a nightmare

A prompt suggests me to "set up recovery". When I put my security Phrase and hit "continue" it just closes with the message suggesting "set up recovery" still there.

This sounds like #22893.

[richvdh]

Hrm maybe not #22893; please do add screenshots to your description though.

[tuxayo]

Please don't tell us what the JS console says; it's probably misleading.

ok good to know to not read to much into these.

If you think there is more than one problem

On the contrary. I think (for what it's worth) that both the happy and unhappy path lead to nothing really happening and that the cause might be the same.

Screenshots:

1.The toast

2. Asking for security phrase:
   

3. Back to main view with the toast (this is an issue, it doesn't seem to have actually set up secure backup):
   

4. Retry but choose to use security key this time:
   

5. Back to main view with the toast (this is an issue, it doesn't seem to have actually set up secure backup):
   

6. Retry but with nonsense security phrase.

7. Back to main view with the toast (this is an issue, it should say something about my nonsense phrase):
   

[tuxayo]

I just send another /rageshake after doing the above

[tuxayo]

This sounds like #22893.

Well, actually I had that on another device (element web also) for years.

But I rechecked and not anymore.

That other device had the "setting up security backup" toast for and it worked for that one.

And it unblocked the new device! No more toast!

I would have stayed stuck there if I didn't have the old device.

I don't know if the screenshots and additional rageshake logs still provide a hint on the root cause.

[richvdh]

Right, thanks for the screenshots and rageshake, they were helpful in reproducing the problem. I've opened #29141 to track. Glad you got it fixed.