Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't enable sliding sync with Conduit #26504

Closed
lnicola opened this issue Nov 5, 2023 · 8 comments · Fixed by matrix-org/matrix-react-sdk#11936
Closed

Can't enable sliding sync with Conduit #26504

lnicola opened this issue Nov 5, 2023 · 8 comments · Fixed by matrix-org/matrix-react-sdk#11936
Assignees
Labels
A-Sliding-Sync Also known as Sync v3 - https://github.com/matrix-org/sliding-sync T-Defect

Comments

@lnicola
Copy link

lnicola commented Nov 5, 2023

Steps to reproduce

  1. log in to a Conduit HS
  2. try to enable sliding sync

Outcome

What did you expect?

It works.

What happened instead?

  • the server responds after 30 seconds, but Element times out after 5 seconds (okay, maybe this is on the server)
  • if it didn't time out in the previous step, Element still seems to try to validate the proxy address even if empty by requesting /client/server.json, which Conduit doesn't know about

Operating system

Linux

Browser information

Firefox

URL for webapp

1.11.47

Application version

No response

Homeserver

Conduit 0.7.0-alpha

Will you send logs?

No

@lnicola lnicola changed the title Can't enable sliding sync Can't enable sliding sync with Conduit Nov 5, 2023
@weeman1337 weeman1337 added Z-Labs X-Needs-Info This issue is blocked awaiting information from the reporter A-Sliding-Sync Also known as Sync v3 - https://github.com/matrix-org/sliding-sync labels Nov 6, 2023
@weeman1337
Copy link
Contributor

@lnicola Thank you for opening an issue. Unfortunately there is not enough information there for me to be able to reproduce it.

Can you send logs? Does it work with the Element X mobile clients?

@lnicola
Copy link
Author

lnicola commented Nov 6, 2023

Yes, it works with Element X and I can send the logs, but I think a screen recording would be more clear. Anyway, I'll try to patch Conduit to work around the timeout first.

@lnicola
Copy link
Author

lnicola commented Nov 21, 2023

Buggy form validation:

image

Logs uploaded.

@t3chguy
Copy link
Member

t3chguy commented Nov 21, 2023

It is expecting the server.json file from the proxy, right now it only supports the proxy https://github.com/matrix-org/sliding-sync/blob/a8fb52626110b8084e0cc6026a894ce3093eaefb/v3.go#L178

@lnicola
Copy link
Author

lnicola commented Nov 21, 2023

I managed to enable it, it's currently making a lot of requests (reloading the history?).

The client/server.json request goes to the Element URL, so there's no need to modify the server, dropping a file in there is enough.

@lnicola
Copy link
Author

lnicola commented Nov 21, 2023

Update: it's making a bajillion requests to _matrix/client/unstable/org.matrix.msc3575/sync?pos=XXXXXX&timeout=20000, where pos is increasing each time by 1 (it's around 385000 at the moment) and the server replies with pretty much the same thing to each of those.

I suspect it's indeed not working very well.

@t3chguy
Copy link
Member

t3chguy commented Nov 21, 2023

If the pos is increasing then the server is sending it incremental data, the way both sync APIs work is long-polling, the server shouldn't respond if it has nothing to send until the timeout is reached. The issue you are hitting is therefore on the server side.

@girlbossceo
Copy link

The other issue is most likely due to matrix-org/sliding-sync@e3b110e which I reported https://gitlab.com/famedly/conduit/-/issues/404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Sliding-Sync Also known as Sync v3 - https://github.com/matrix-org/sliding-sync T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants